CompatHelper: bump compat for Convex to 0.16 for package test, (keep existing compat) #1953
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
force-pushed
the
compathelper/new_version/2024-05-24-00-05-50-221-03419143078
branch
from
93a7548 to
b848fae
Compare
|
@ranocha do you know why no tests are running/queued? |
|
No idea. I just merged @DanielDoehring Any breaking changes in Convex.jl affecting your workload? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1953 +/- ##
==========================================
- Coverage 96.11% 92.60% -3.51%
==========================================
Files 460 460
Lines 36926 36894 -32
==========================================
- Hits 35490 34164 -1326
- Misses 1436 2730 +1294
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@DanielDoehring CI fails due to deprecations (https://github.com/trixi-framework/Trixi.jl/actions/runs/9218674674/job/25362597322?pr=1953#step:7:825) and changes of the results (https://github.com/trixi-framework/Trixi.jl/actions/runs/9218674674/job/25362595206?pr=1953#step:7:1722). Please check whether everything is okay, update the code as required, drop support of the old version of Convex.jl, and ping me when everything is ready to be merged. |
|
The differences in the Butcher array variables are marginal, so that looks ok. |
ranocha
deleted the
compathelper/new_version/2024-05-24-00-05-50-221-03419143078
branch
This pull request changes the compat entry for the
Convexpackage from0.15.4to0.15.4, 0.16for package test.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.